Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display: Allow limited view access to non-destructive edit-only features #2718

Merged
merged 3 commits into from
Aug 29, 2024

Conversation

mgbaybay
Copy link
Contributor

Changes

  • Display: Allow limited view access to non-destructive edit-only features

Relates to: xibosignage/xibo#3479

@mgbaybay mgbaybay force-pushed the feature/giacobini_update_display_view_permission branch from 96356df to 6b770fc Compare August 28, 2024 07:01
Copy link
Member

@dasgarner dasgarner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a different approach we can take here, please can we review this one together.

@mgbaybay mgbaybay force-pushed the feature/giacobini_update_display_view_permission branch from 6b770fc to e043fee Compare August 28, 2024 09:54
Copy link
Member

@dasgarner dasgarner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much more inline with the intension! great.

I have one comment regarding the display group access

lib/Controller/DisplayGroup.php Outdated Show resolved Hide resolved
@ifarzana
Copy link
Contributor

TEST: /Administration END

Copy link

@ifarzana
Copy link
Contributor

TEST: /Administration END

Copy link

@mgbaybay mgbaybay merged commit 30587e3 into develop Aug 29, 2024
4 checks passed
@mgbaybay mgbaybay deleted the feature/giacobini_update_display_view_permission branch August 29, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants