Schedule Criteria: weather "clear sky" condition does not match #2740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
relates to xibosignage/xibo#3487 - Modified metric IDs to better align with JSON responses from the OWM API. - Added a prefix to avoid conflicts with other potential weather schedule criteria. - Removed metrics that are not present in OpenWeather API responses.
relates to xibosignage/xibo#3487 - Added a prefix to the weather XMDS response. - Restored Wind Direction with fewer options after it was previously removed.
PeterMis
previously approved these changes
Sep 19, 2024
PeterMis
previously approved these changes
Sep 20, 2024
dasgarner
requested changes
Oct 1, 2024
relates to xibosignage/xibo#3487 - Updated the weather schedule criteria's and XMDS getWeather's prefix.
dasgarner
previously approved these changes
Oct 1, 2024
relates to xibosignage/xibo#3487 - Fixed the formatting of weather condition values. - Set the `type` criteria as the prefix for the metric's value
dasgarner
approved these changes
Oct 2, 2024
|
TEST: /Schedule END |
|
Test Suite: succeeded ✅ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relates to xibosignage/xibo#3487