Layouts: Fix Canvas only layouts should set their duration from any images added or a 10 second minimum #2755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mages added or a 10 second minimum
dasgarner
previously approved these changes
Oct 2, 2024
|
TEST: /Display END |
|
Test Suite: succeeded ✅ |
mgbaybay
force-pushed
the
bugfix/layouts_update_canvas_only_layout_duration
branch
from
6a633d9
to
1a44e52
Compare
mgbaybay
force-pushed
the
bugfix/layouts_update_canvas_only_layout_duration
branch
from
1a44e52
to
35ce585
Compare
dasgarner
approved these changes
Oct 17, 2024
|
TEST: /Layout END |
|
Test Suite: failed ❌ |
|
TEST: /Display, /Layout/Editor/layout_editor_dataset.cy.js, /Layout/Editor/layout_editor_rss_ticker.cy.js END |
|
Test Suite: failed ❌ |
|
TEST: /Layout/Editor/layout_editor_dataset.cy.js, /Layout/Editor/layout_editor_rss_ticker.cy.js END |
|
Test Suite: succeeded ✅ |
mgbaybay
deleted the
bugfix/layouts_update_canvas_only_layout_duration
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Relates to: xibosignage/xibo#3499