Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display: Non-destructive feature should include send command #2768

Merged
merged 2 commits into from
Oct 16, 2024
Merged

Display: Non-destructive feature should include send command #2768

merged 2 commits into from
Oct 16, 2024

Conversation

mgbaybay
Copy link
Contributor

Changes

  • Add Send Command in non-destructive feature

Relates to: xibosignage/xibo#3533

@mgbaybay mgbaybay self-assigned this Oct 14, 2024
nadzpogi
nadzpogi reviewed Oct 15, 2024
View reviewed changes
Copy link
Contributor

@nadzpogi nadzpogi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might be mistaken, but I think you should also add this:

!$this->getUser()->featureEnabled('displays.limitedView')

in lib/Controller/DisplayGroup.php at line 2513

@mgbaybay
Copy link
Contributor Author

I might be mistaken, but I think you should also add this:

!$this->getUser()->featureEnabled('displays.limitedView')

in lib/Controller/DisplayGroup.php at line 2513

You're right, thank you for this! Please see latest commit . :)

nadzpogi
nadzpogi approved these changes Oct 15, 2024
View reviewed changes
Copy link
Contributor

@nadzpogi nadzpogi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good!

@gracec20
Copy link
Contributor

TEST: /Administration, /Display END

@github-actions GitHub Actions
Copy link

Test Suite: succeeded ✅
https://github.com/xibosignage/xibo-cms/actions/runs/11351859936

@mgbaybay mgbaybay merged commit 4b81b29 into develop Oct 16, 2024
2 of 3 checks passed
@mgbaybay mgbaybay deleted the feature/display_update_send_command branch October 16, 2024 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nadzpogi nadzpogi nadzpogi approved these changes

Assignees

@mgbaybay mgbaybay

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mgbaybay @gracec20 @nadzpogi