-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cypress Test: Layout Status Bar, Background, and Layout Options #2791
Conversation
gracec20
commented
Nov 4, 2024
- Layout Background
- Background Colour Selection Using Colour Picker
- Background Colour Selection Using Hex Input
- Change Resolution
- Layout Options
- Publish Empty Layout
- Checkout
- Discard Layout
- Create New Layout
- Unlock
- Enable Tooltips
- Disable Tooltips
- Enable Delete Confirmation
- Disable Delete Confirmation
- Publish an Invalid Layout
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
I have a few comments; once those are fixed, we can approve and merge the PR.
// Verify that tooltips are present | ||
cy.get('.navbar-nav .btn-menu-option[data-toggle="tooltip"]').each(($element) => { | ||
// Trigger hover to show tooltip | ||
cy.wrap($element).trigger('mouseenter'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please change this to mouseover
instead of mouseenter
, because mouseenter does not reveal the tooltip?
|
||
// Verify that tooltips are gone | ||
cy.get('.navbar-nav .btn-menu-option[data-toggle="tooltip"]').each(($element) => { | ||
cy.wrap($element).trigger('mouseenter'); // Trigger hover to show tooltip |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mouseenter does not reveal the tooltip
}); | ||
|
||
// Add an element then attempt to delete | ||
cy.openToolbarMenu(0); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can modify the openToolbarMenu command to accept an additional parameter that indicates whether to wait for the toolbar preferences to load. If load is set to false, the command will skip the following two lines:
// Wait for the toolbar to reload when getting prefs at start, based on the load parameter
if (load) {
cy.wait('@toolbarPrefsLoad');
cy.wait('@editorPrefsLoad');
}
…added condition to openToolbarMenu command
TEST: /Layout END |
Test Suite: failed ❌ |
TEST: /Layout END |
Test Suite: failed ❌ |
TEST: /Layout END |
Test Suite: failed ❌ |
TEST: /Layout/Editor/layout_editor_rss_ticker.cy.js, /Layout/Editor/layout_editor_dataset.cy.js, /Layout/Editor/layout_editor_mastodon.cy.js END |
Test Suite: succeeded ✅ |
TEST: /Layout/Editor/layout_editor_options.cy.js END |
Test Suite: failed ❌ |
TEST: /Layout/Editor/layout_editor_options.cy.js END |
Test Suite: failed ❌ |
TEST: /Layout/Editor/layout_editor_options.cy.js END |
Test Suite: failed ❌ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are reverting and approving this PR. We'll investigate later why there are flaky test results.
TEST: /Layout/Editor/layout_editor_rss_ticker.cy.js END |
Test Suite: failed ❌ |
TEST: /Layout/Editor/layout_editor_clock.cy.js END |
Test Suite: succeeded ✅ |
Do you want me to bypass the signed commits check on this occasion (I assume we have manually verified they all came from the right place)? |
Yes, it is manually verified. Let’s go ahead and merge this if you can bypass the rule, as we don’t have enough time to troubleshoot the sign today. Thanks |