Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cypress Test: Layout Status Bar, Background, and Layout Options #2791

Merged
merged 7 commits into from
Nov 7, 2024

Conversation

gracec20
Copy link
Contributor

@gracec20 gracec20 commented Nov 4, 2024

  1. Layout Background
  • Background Colour Selection Using Colour Picker
  • Background Colour Selection Using Hex Input
  • Change Resolution
  1. Layout Options
  • Publish Empty Layout
  • Checkout
  • Discard Layout
  • Create New Layout
  • Unlock
  • Enable Tooltips
  • Disable Tooltips
  • Enable Delete Confirmation
  • Disable Delete Confirmation
  • Publish an Invalid Layout

@gracec20 gracec20 self-assigned this Nov 4, 2024
Copy link
Contributor

@ifarzana ifarzana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!
I have a few comments; once those are fixed, we can approve and merge the PR.

// Verify that tooltips are present
cy.get('.navbar-nav .btn-menu-option[data-toggle="tooltip"]').each(($element) => {
// Trigger hover to show tooltip
cy.wrap($element).trigger('mouseenter');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please change this to mouseover instead of mouseenter, because mouseenter does not reveal the tooltip?


// Verify that tooltips are gone
cy.get('.navbar-nav .btn-menu-option[data-toggle="tooltip"]').each(($element) => {
cy.wrap($element).trigger('mouseenter'); // Trigger hover to show tooltip
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mouseenter does not reveal the tooltip

});

// Add an element then attempt to delete
cy.openToolbarMenu(0);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can modify the openToolbarMenu command to accept an additional parameter that indicates whether to wait for the toolbar preferences to load. If load is set to false, the command will skip the following two lines:

  // Wait for the toolbar to reload when getting prefs at start, based on the load parameter
  if (load) {
    cy.wait('@toolbarPrefsLoad');
    cy.wait('@editorPrefsLoad');
  }

ifarzana
ifarzana previously approved these changes Nov 6, 2024
@ifarzana
Copy link
Contributor

ifarzana commented Nov 6, 2024

TEST: /Layout END

Copy link

github-actions bot commented Nov 6, 2024

@ifarzana
Copy link
Contributor

ifarzana commented Nov 6, 2024

TEST: /Layout END

Copy link

github-actions bot commented Nov 6, 2024

ifarzana
ifarzana previously approved these changes Nov 6, 2024
@ifarzana
Copy link
Contributor

ifarzana commented Nov 6, 2024

TEST: /Layout END

Copy link

github-actions bot commented Nov 6, 2024

@ifarzana
Copy link
Contributor

ifarzana commented Nov 6, 2024

TEST: /Layout/Editor/layout_editor_rss_ticker.cy.js, /Layout/Editor/layout_editor_dataset.cy.js, /Layout/Editor/layout_editor_mastodon.cy.js END

Copy link

github-actions bot commented Nov 6, 2024

ifarzana
ifarzana previously approved these changes Nov 6, 2024
@ifarzana
Copy link
Contributor

ifarzana commented Nov 6, 2024

TEST: /Layout/Editor/layout_editor_options.cy.js END

Copy link

github-actions bot commented Nov 6, 2024

@ifarzana
Copy link
Contributor

ifarzana commented Nov 6, 2024

TEST: /Layout/Editor/layout_editor_options.cy.js END

Copy link

github-actions bot commented Nov 6, 2024

ifarzana
ifarzana previously approved these changes Nov 6, 2024
@ifarzana
Copy link
Contributor

ifarzana commented Nov 6, 2024

TEST: /Layout/Editor/layout_editor_options.cy.js END

Copy link

github-actions bot commented Nov 6, 2024

Copy link
Contributor

@ifarzana ifarzana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are reverting and approving this PR. We'll investigate later why there are flaky test results.

@ifarzana
Copy link
Contributor

ifarzana commented Nov 6, 2024

TEST: /Layout/Editor/layout_editor_rss_ticker.cy.js END

Copy link

github-actions bot commented Nov 6, 2024

@ifarzana
Copy link
Contributor

ifarzana commented Nov 6, 2024

TEST: /Layout/Editor/layout_editor_clock.cy.js END

Copy link

github-actions bot commented Nov 6, 2024

@dasgarner
Copy link
Member

Do you want me to bypass the signed commits check on this occasion (I assume we have manually verified they all came from the right place)?

@ifarzana
Copy link
Contributor

ifarzana commented Nov 7, 2024

Yes, it is manually verified. Let’s go ahead and merge this if you can bypass the rule, as we don’t have enough time to troubleshoot the sign today.

Thanks

@dasgarner dasgarner merged commit 67de690 into develop Nov 7, 2024
2 checks passed
@ifarzana ifarzana deleted the cypress-test-layout-editor branch November 7, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants