Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unwanted alert window: Unexpected use of reserved word 'let' in strict mode #245

Open
Commifreak opened this issue Jun 8, 2021 · 4 comments
Labels
Milestone

Comments

@Commifreak
Copy link

Describe the bug
One region, one HTML View: The linux player embedded HTML viewer has problems with Javascript's let keyword.

To Reproduce
Embed HTML page with let Javascript? I included Check_MK dashboard to let this happen.

Expected behavior
No JS error

Logs
not applicable

Screenshots
grafik

Environment (please complete the following information):

  • Linux Disto: Ubuntu 20.04
  • Linux Desktop Environment: GNOME
  • How the player was launched: snap
  • Player Version: 1.8-R6
@Commifreak Commifreak added the bug label Jun 8, 2021
@dasgarner
Copy link
Member

dasgarner commented Jun 8, 2021

The Linux player browser engine does not support ES6 syntax which is why you're getting this error (that same page would not work in many older Android devices, IE or Safari 8, either).

The only recourse in this case is to update the source web page for ES5.

We should not show the alert dialog though! So I will re-purpose this bug report for that.

@dasgarner dasgarner changed the title Error: Unexpected use of reserved word 'let' in strict mode Unwanted alert window: Unexpected use of reserved word 'let' in strict mode Jun 8, 2021
@dasgarner dasgarner added this to the 1.8 R7 milestone Jun 8, 2021
@Commifreak
Copy link
Author

Maybe it would be better to upgrade the browser engine to support ES6?

@dasgarner
Copy link
Member

We have an open PR for this, which outlines the problems we're facing doing that: #179

Currently we're faced with building WebKitGTK entirely from source, which really isn't optimal.

If you would like to take a look at it and update the PR then that would be much appreciated.

@Commifreak
Copy link
Author

Thats something I can't help with. I can program in PHP - thats all :)

@dasgarner dasgarner modified the milestones: 1.8 R7, 1.8 R8 May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants