Merge pull request #93 from diogoosorio/92-fix-list-paragraph-newlines

Fixes unintentional newline characters within lists with paragraphs
xijo · Oct 31, 2021 · 2eab8dd · 2eab8dd
2 parents c664cad + 3732a3b
commit 2eab8dd
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 3 deletions.
diff --git a/lib/reverse_markdown/converters/li.rb b/lib/reverse_markdown/converters/li.rb
@@ -2,8 +2,8 @@ module ReverseMarkdown
   module Converters
     class Li < Base
       def convert(node, state = {})
-        contains_child_paragraph = node.children.first ? node.children.first.name == 'p' : false
-        content_node             = contains_child_paragraph ? node.children.first : node
+        contains_child_paragraph = node.first_element_child ? node.first_element_child.name == 'p' : false
+        content_node             = contains_child_paragraph ? node.first_element_child : node
         content                  = treat_children(content_node, state)
         indentation              = indentation_from(state)
         prefix                   = prefix_for(node)

diff --git a/spec/assets/lists.html b/spec/assets/lists.html
@@ -44,6 +44,8 @@
       </li>
     </ul>
 
+    <ul><li> <p>I don't want to cleanup after the party!</p> </li></ul>
+
     <ul>
       <li>
         <p>li 1, p 1</p>

diff --git a/spec/components/lists_spec.rb b/spec/components/lists_spec.rb
@@ -35,7 +35,8 @@
   end
 
   context "lists containing embedded <p> tags" do
-    xit { is_expected.to match /\n- I want to have a party at my house!\n/ }
+    it { is_expected.to match /\n- I want to have a party at my house!\n/ }
+    it { is_expected.to match /\n- I don't want to cleanup after the party!\n/ }
   end
 
   context "list item containing multiple <p> tags" do