Support frozen string literals #105
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to avoid deprecation warnings with the forthcoming change in Ruby 3.4 where modifying a string literal will cause a deprecation warning by default. ruby/ruby@12be40a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to avoid deprecation warnings with the forthcoming change in Ruby 3.4 where modifying a string literal will cause a deprecation warning by default.
ruby/ruby@12be40a
Essentially, I'm just marking some of the string literals as explicitly not-frozen, because it's clear they're going to be modified.
I've tested this by running the test suite with
RUBYOPT="--enable-frozen-string-literal --debug-frozen-string-literal". However, the last version ofcodeclimate-test-reporterrequires a very outdated version of simplecov which has not been patched to handle frozen string literals - but removing thecodeclimate-test-reporterdependency and upgrading simplecov gets all the tests green.It seems that
codeclimate-test-reporteris deprecated anyway.https://docs.codeclimate.com/docs/configuring-test-coverage