Lets \n to be present in <pre> tag. solves #77 #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xijo
reviewed
May 23, 2020
| @@ -17,6 +17,9 @@ def treat(node, state) | |||
| case node.name | |||
| when 'code' | |||
| node.text | |||
| when 'text' | |||
| # Preserve '\n' in the middle of text/words, get rid of indentation spaces | |||
| ReverseMarkdown.cleaner.remove_leading_newlines(node.text.gsub("\n", '<br>').strip.gsub('<br>', "\n")) | |||
There was a problem hiding this comment.
AFAICS this can be simplified to
Suggested change
| ReverseMarkdown.cleaner.remove_leading_newlines(node.text.gsub("\n", '<br>').strip.gsub('<br>', "\n")) | |
| node.text |
At least it will pass all provided test cases, right?
There was a problem hiding this comment.
@shivabhusal, can you look into this PR when you get a chance?
Seems to me like @xijo's proposal works just fine:
when 'code', 'text'
node.text
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It solves the issue I reported: #77