Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This xmake package is not building on Manjaro, I want to see what happens in with the automated testing on other platforms.
It fails because it cant find
tl_expected
. Building the saucer project directly with CMake does work.For some reason a check in the cmake file polyfill.cmake is not running, which checks for
std::expected
. This is the CMake output for that section is this when building saucer directly:... and the output when CMake is invoked from this package is:
I've tried recreating by mirroring the xmake CMake invocation when building saucer directly with CMake but I can't replicate.