update folly to 2024.10.07 #5505
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Version 2024.10.14 introduced an incompatibility with an older version of MSVC in this commit: So I suggest to skip this version for now and update to the latest working version on all platforms, so as not to add unnecessary patches. |
c8ef
approved these changes
Oct 16, 2024
| void test() { | ||
| folly::AsyncIOOp asyncIOOp; | ||
| } | ||
| ]]}, {configs = {languages = "c++17"}, includes = "folly/experimental/io/AsyncIO.h"})) |
There was a problem hiding this comment.
The headers have been moved in the commit at: facebook/folly@e5d54e8. You may need to update these includes accordingly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.