Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libunifex: add package #5485

Merged
merged 12 commits into from
Oct 14, 2024
Merged

libunifex: add package #5485

merged 12 commits into from
Oct 14, 2024

Conversation

Doekin
Copy link
Contributor

@Doekin Doekin commented Oct 13, 2024

No description provided.

Copy link
Member

@c8ef c8ef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG with some nits.

auto delay(milliseconds ms) {
return schedule_after(current_scheduler, ms);
}
]]}, {configs = {languages = "c++20"},includes = {"chrono", "unifex/on.hpp", "unifex/scheduler_concepts.hpp"}}))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
]]}, {configs = {languages = "c++20"},includes = {"chrono", "unifex/on.hpp", "unifex/scheduler_concepts.hpp"}}))
]]}, {configs = {languages = "c++20"}, includes = {"chrono", "unifex/on.hpp", "unifex/scheduler_concepts.hpp"}}))

Comment on lines 23 to 26
local configs = { "-DBUILD_TESTING=OFF",
"-DUNIFEX_BUILD_EXAMPLES=OFF",
"-DCMAKE_CXX_STANDARD=20",
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
local configs = { "-DBUILD_TESTING=OFF",
"-DUNIFEX_BUILD_EXAMPLES=OFF",
"-DCMAKE_CXX_STANDARD=20",
}
local configs = {"-DBUILD_TESTING=OFF",
"-DUNIFEX_BUILD_EXAMPLES=OFF",
"-DCMAKE_CXX_STANDARD=20"}

@Doekin
Copy link
Contributor Author

Doekin commented Oct 13, 2024

Something went wrong with shared lib on Windows

@Doekin Doekin closed this Oct 13, 2024
@star-hengxing
Copy link
Contributor

You can disable shared on windows.

@star-hengxing star-hengxing reopened this Oct 13, 2024
@Doekin
Copy link
Contributor Author

Doekin commented Oct 13, 2024

Incredible

@waruqi waruqi merged commit 73945e3 into xmake-io:dev Oct 14, 2024
67 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants