Merge pull request #4306 from SirLynix/patch-14

cmakelists: restore system headers
xmake-io · Oct 20, 2023 · 7a84db2 · 7a84db2
2 parents 0ca9061 + 9991a20
commit 7a84db2
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/xmake/plugins/project/cmake/cmakelists.lua b/xmake/plugins/project/cmake/cmakelists.lua
@@ -450,16 +450,15 @@ end
 function _add_target_sysinclude_directories(cmakelists, target, outputdir)
     local includedirs = _get_configs_from_target(target, "sysincludedirs")
     if #includedirs > 0 then
-        -- TODO should be `SYSTEM PRIVATE`
-        cmakelists:print("target_include_directories(%s PRIVATE", target:name())
+        cmakelists:print("target_include_directories(%s SYSTEM PRIVATE", target:name())
         for _, includedir in ipairs(includedirs) do
             cmakelists:print("    " .. _get_relative_unix_path(includedir, outputdir))
         end
         cmakelists:print(")")
     end
     local includedirs_interface = target:get("sysincludedirs", {interface = true})
     if includedirs_interface then
-        cmakelists:print("target_include_directories(%s INTERFACE", target:name())
+        cmakelists:print("target_include_directories(%s SYSTEM INTERFACE", target:name())
         for _, headerdir in ipairs(includedirs_interface) do
             cmakelists:print("    " .. _get_relative_unix_path(headerdir, outputdir))
         end