From 9991a20e1302dc7cb1df77bd0771e052b9a5e429 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?J=C3=A9r=C3=B4me=20Leclercq?= Date: Fri, 20 Oct 2023 10:41:32 +0200 Subject: [PATCH] cmakelists: restore system headers It's been three years since #1050 and msvc has stable external header support now, I think we can now re-enable system headers for cmakelists --- xmake/plugins/project/cmake/cmakelists.lua | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/xmake/plugins/project/cmake/cmakelists.lua b/xmake/plugins/project/cmake/cmakelists.lua index 9d66cba4897..d186b0a023a 100644 --- a/xmake/plugins/project/cmake/cmakelists.lua +++ b/xmake/plugins/project/cmake/cmakelists.lua @@ -450,8 +450,7 @@ end function _add_target_sysinclude_directories(cmakelists, target, outputdir) local includedirs = _get_configs_from_target(target, "sysincludedirs") if #includedirs > 0 then - -- TODO should be `SYSTEM PRIVATE` - cmakelists:print("target_include_directories(%s PRIVATE", target:name()) + cmakelists:print("target_include_directories(%s SYSTEM PRIVATE", target:name()) for _, includedir in ipairs(includedirs) do cmakelists:print(" " .. _get_relative_unix_path(includedir, outputdir)) end @@ -459,7 +458,7 @@ function _add_target_sysinclude_directories(cmakelists, target, outputdir) end local includedirs_interface = target:get("sysincludedirs", {interface = true}) if includedirs_interface then - cmakelists:print("target_include_directories(%s INTERFACE", target:name()) + cmakelists:print("target_include_directories(%s SYSTEM INTERFACE", target:name()) for _, headerdir in ipairs(includedirs_interface) do cmakelists:print(" " .. _get_relative_unix_path(headerdir, outputdir)) end