Implement stdmodule clang detection flag #4805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arthapz
force-pushed
the
implement-stdmodule-clang-detection-flag
branch
from
349a7fb
to
919493c
Compare
waruqi
reviewed
Mar 7, 2024
xmake/rules/c++/modules/modules_support/clang/compiler_support.lua
Outdated
Show resolved
Hide resolved
waruqi
reviewed
Mar 7, 2024
xmake/rules/c++/modules/modules_support/clang/compiler_support.lua
Outdated
Show resolved
Hide resolved
waruqi
reviewed
Mar 7, 2024
xmake/rules/c++/modules/modules_support/clang/compiler_support.lua
Outdated
Show resolved
Hide resolved
Arthapz
force-pushed
the
implement-stdmodule-clang-detection-flag
branch
from
c7ece67
to
1cf7d42
Compare
|
Is it ok now? |
waruqi
reviewed
Mar 12, 2024
they have opened a new PR llvm/llvm-project#84881 |
Arthapz
force-pushed
the
implement-stdmodule-clang-detection-flag
branch
from
9fcf046
to
c13e8d5
Compare
|
The PR got merged, but i don't get it to work on my setup (see llvm/llvm-project#84881 (comment)) so i'll pass this to ready when i confirmed it's working |
better lisibility
…-manifest-path doesn't find libc++.module.json
Arthapz
force-pushed
the
implement-stdmodule-clang-detection-flag
branch
from
65b5f53
to
8087574
Compare
|
i tried it and it work, fallback work too |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
draft because the flag got re-reverted a second time :D but it should be backported to llvm18 this week, see llvm/llvm-project#82160