Fix xm_engine_get_program_file for NetBSD #4508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It does not work for freebsd |
#2948 seemed to suggest that But that also means that |
…e used for FreeBSD and OpenBSD) doesn't work with NetBSD. Using /proc/curproc/exe works and is the preferred option.
cmeerw
force-pushed
the
fix-netbsd-get-program-file
branch
from
a1fbac2
to
bf8e4fe
Compare
|
According to https://stackoverflow.com/questions/1023306/finding-current-executables-path-without-proc-self-exe/1024937#1024937 |
|
thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NetBSD defines
KERN_PROC_PATHNAME, but thesysctl(that should only be used for OpenBSD) doesn't work with NetBSD. Using/proc/curproc/exeworks and is the preferred option.