implement module reusage based on flag comparison #4728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waruqi
reviewed
Feb 11, 2024
|
I have merged #4707 |
fix gcc fix msvc fix msvc fix msvc fix
Arthapz
force-pushed
the
reuse-modules
branch
from
f491983
to
1a6c4c2
Compare
|
|
|
you can use xmake/xmake/modules/core/project/depend.lua Line 109 in c601bfa |
|
So to explain this PR, the objective is to reuse BMI of deps targets if flags are compatible on my personal C++ toolkit with a hundred modules, build times got reduce from ~110 seconds to 70 seconds with LLVm |
waruqi
reviewed
Feb 13, 2024
waruqi
reviewed
Feb 13, 2024
waruqi
reviewed
Feb 13, 2024
xmake/rules/c++/modules/modules_support/gcc/compiler_support.lua
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR is based on #4707, i'll rebase on modules branch after merging #4707