Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Passing is_debug to gn #4783

Merged
merged 1 commit into from
Feb 29, 2024
Merged

fix: Passing is_debug to gn #4783

merged 1 commit into from
Feb 29, 2024

Conversation

PerikiyoXD
Copy link
Contributor

I've tried to build v8, failing because a few errors.
I encountered that gn wouldn't take is_debug in some cases, thus needing a ternary check to always pass true or false.

Without fix:

gn.bat gen out.gn "--args=target_cpu=\"x64\" use_custom_libcxx=false target_os=\"win\" is_clang=false treat_warnings_as_errors=false is_official_build=false v8_enable_test_features=false is_shared_library=false is_component_build=false v8_enable_i18n_support=false extra_cflags=[\"/MT\"] v8_monolithic=true v8_use_external_startup_data=false symbol_level=0 v8_static_library=true"

With fix:

gn.bat gen out.gn "--args=v8_enable_test_features=false is_component_build=false treat_warnings_as_errors=false is_clang=false extra_cflags=[\"/MT\"] v8_enable_i18n_support=false is_official_build=false target_cpu=\"x64\" is_shared_library=false symbol_level=0 target_os=\"win\" v8_monolithic=true v8_static_library=true use_custom_libcxx=false is_debug=false v8_use_external_startup_data=false"

Relevant part: is_debug=

It would never put the is_debug=false even if it was defined in the config.

An update to v8 will be posted soon.

@waruqi waruqi changed the base branch from master to dev February 29, 2024 02:18
@waruqi waruqi added this to the v2.8.8 milestone Feb 29, 2024
@waruqi waruqi merged commit 7659e6d into xmake-io:dev Feb 29, 2024
17 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants