Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xpack: wix toolset support #5153

Merged
merged 28 commits into from
May 28, 2024
Merged

Xpack: wix toolset support #5153

merged 28 commits into from
May 28, 2024

Conversation

waruqi
Copy link
Member

@waruqi waruqi commented May 27, 2024

Closes #4637

#4788

@waruqi waruqi added this to the v2.9.3 milestone May 27, 2024
@waruqi waruqi mentioned this pull request May 27, 2024
3 tasks
@waruqi
Copy link
Member Author

waruqi commented May 27, 2024

@A2va I tried pack xmake installer, but it does not work.

$ cd core
$ xmake
$ xmake pack -f wix --autobuild=n
error: D:\projects\personal\xmake\core\build\.xpack\xmake\xmake-v2.9.2.win64.wxs(35) : error WIX0014: The Feature/@Id attribute's value, 'Xmakebuildutility(x64)', is not a legal identifier. Identifiers may contain ASCII characters A-Z, a-z, digits, underscores (_), or periods (.). Every identifier must begin with either a letter or an underscore.
D:\projects\personal\xmake\core\build\.xpack\xmake\xmake-v2.9.2.win64.wxs(35) : error WIX0010: The Feature/@Id attribute was not found; it is required.
D:\projects\personal\xmake\core\build\.xpack\xmake\xmake-v2.9.2.win64.wxs(3281) : error WIX0014: The Component/@Id attribute's value, 'Xmakebuildutility(x64)Cmds', is not a legal identifier. Identifiers may contain ASCII characters A-Z, a-z, digits, underscores (_), or periods (.). Every identifier must begin with either a letter or an underscore.
D:\projects\personal\xmake\core\build\.xpack\xmake\xmake-v2.9.2.win64.wxs(3281) : error WIX0330: The Component/@Id attribute was not found; it is required when there is no valid keypath to use as the default id value.

@waruqi
Copy link
Member Author

waruqi commented May 28, 2024

I have fixed this error, but there is anthor error

D:\projects\personal\xmake\core\build\.xpack\xmake\xmake-v2.9.2.win64.wxs(5225) : error WIX0092: Location of symbol related to previous error.
D:\projects\personal\xmake\core\build\.xpack\xmake\xmake-v2.9.2.win64.wxs(4736) : error WIX0091: Duplicate RemoveFile with identifier 'rmf0oCqvYQbknPTgDniR34St_BgCU4' found. Access modifiers (global, library, file, section) cannot prevent these conflicts. Ensure all your identifiers of a given type (Directory, File, etc.) are unique.
D:\projects\personal\xmake\core\build\.xpack\xmake\xmake-v2.9.2.win64.wxs(5228) : error WIX0092: Location of symbol related to previous error.
D:\projects\personal\xmake\core\build\.xpack\xmake\xmake-v2.9.2.win64.wxs(4737) : error WIX0091: Duplicate RemoveFile with identifier 'rmfU3ucLJrx6uOld.D0WnvSbYxXiZE' found. Access modifiers (global, library, file, section) cannot prevent these conflicts. Ensure all your identifiers of a given type (Directory, File, etc.) are unique.
D:\projects\personal\xmake\core\build\.xpack\xmake\xmake-v2.9.2.win64.wxs(5229) : error WIX0092: Location of symbol related to previous error.
D:\projects\personal\xmake\core\build\.xpack\xmake\xmake-v2.9.2.win64.wxs(4738) : error WIX0091: Duplicate RemoveFile with identifier 'rmfzjs2OMlS1T9GdL4bQgtagxhFKxk' found. Access modifiers (global, library, file, section) cannot prevent these conflicts. Ensure all your identifiers of a given type (Directory, File, etc.) are unique.
D:\projects\personal\xmake\core\build\.xpack\xmake\xmake-v2.9.2.win64.wxs(5232) : error WIX0092: Location of symbol related to previous error.
D:\projects\personal\xmake\core\build\.xpack\xmake\xmake-v2.9.2.win64.wxs(4739) : error WIX0091: Duplicate RemoveFile with identifier 'rmfnkhlHUUAKlk0gBdd7la4m7a3SBc' found. Access modifiers (global, library, file, section) cannot prevent these conflicts. Ensure all your identifiers of a given type (Directory, File, etc.) are unique.

@waruqi
Copy link
Member Author

waruqi commented May 28, 2024

It works now, but its binary size is larger than nsis.

image

@waruqi waruqi merged commit 6975cf5 into dev May 28, 2024
38 checks passed
@waruqi waruqi deleted the wix branch May 28, 2024 02:03
@waruqi waruqi mentioned this pull request May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants