Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: example/default config should work without additional edits #407

Merged
merged 2 commits into from
Jul 18, 2024

Conversation

denopink
Copy link
Contributor

@denopink denopink commented Apr 1, 2024

No description provided.

@denopink
Copy link
Contributor Author

denopink commented Apr 1, 2024

closes xmidt-org/tr1d1um#498

@johnabass johnabass self-assigned this Jul 18, 2024
Copy link

codecov bot commented Jul 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.65%. Comparing base (69859e9) to head (4949302).
Report is 44 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #407      +/-   ##
==========================================
+ Coverage   59.89%   60.65%   +0.75%     
==========================================
  Files          18       18              
  Lines        1778     1431     -347     
==========================================
- Hits         1065      868     -197     
+ Misses        672      522     -150     
  Partials       41       41              
Flag Coverage Δ
unittests 60.65% <ø> (+0.75%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@johnabass johnabass merged commit b968a7b into main Jul 18, 2024
19 checks passed
@johnabass johnabass deleted the denopink/patch/fix-example-config-basic-auth branch July 18, 2024 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants