Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for metric to track the maximum number of devices permitted to connect to a Talaria instance. #454

Merged
merged 4 commits into from
Oct 22, 2024

Conversation

ChaitanyaSingla
Copy link

@ChaitanyaSingla ChaitanyaSingla commented Aug 12, 2024

We need to introduce a metric in Talaria that reflects the maximum number of devices permitted to connect to a Talaria instance. This pull request includes the addition of a metric to monitor the maximum allowed device connections for Talaria.

Reference issue for this MR: #299

cc: @Sachin4403

@CLAassistant
Copy link

CLAassistant commented Aug 12, 2024

CLA assistant check
All committers have signed the CLA.

@johnabass johnabass self-assigned this Oct 7, 2024
@ChaitanyaSingla
Copy link
Author

@johnabass I have already signed the CLA agreement, but it is still showing as pending.

Copy link

codecov bot commented Oct 22, 2024

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Project coverage is 58.60%. Comparing base (94a661b) to head (6745563).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
main.go 0.00% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #454      +/-   ##
==========================================
- Coverage   58.91%   58.60%   -0.32%     
==========================================
  Files          18       18              
  Lines        1862     1872      +10     
==========================================
  Hits         1097     1097              
- Misses        723      733      +10     
  Partials       42       42              
Flag Coverage Δ
unittests 58.60% <0.00%> (-0.32%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@denopink denopink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! 🍻

@denopink denopink merged commit f259b51 into xmidt-org:main Oct 22, 2024
13 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants