-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for metric to track the maximum number of devices permitted to connect to a Talaria instance. #454
Conversation
@johnabass I have already signed the CLA agreement, but it is still showing as pending. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #454 +/- ##
==========================================
- Coverage 58.91% 58.60% -0.32%
==========================================
Files 18 18
Lines 1862 1872 +10
==========================================
Hits 1097 1097
- Misses 723 733 +10
Partials 42 42
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! 🍻
We need to introduce a metric in Talaria that reflects the maximum number of devices permitted to connect to a Talaria instance. This pull request includes the addition of a metric to monitor the maximum allowed device connections for Talaria.
Reference issue for this MR: #299
cc: @Sachin4403