Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patch: replace prometheus WithLabelValues with With #479

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

denopink
Copy link
Contributor

  • simplify the prometheus code
  • fix misunderstanding of WithLabelValues

- simplify the prometheus code
- fix misunderstanding of `WithLabelValues`
@denopink denopink self-assigned this Sep 20, 2024
Copy link

codecov bot commented Sep 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.15%. Comparing base (8f6cebe) to head (bbf19e8).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #479   +/-   ##
=======================================
  Coverage   59.15%   59.15%           
=======================================
  Files          18       18           
  Lines        1496     1496           
=======================================
  Hits          885      885           
  Misses        569      569           
  Partials       42       42           
Flag Coverage Δ
unittests 59.15% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@denopink denopink added the bug label Sep 20, 2024
@denopink denopink merged commit f0ef6c7 into main Sep 20, 2024
19 checks passed
@denopink denopink deleted the denopink/patch/typo-replace-WithLabelValues branch September 20, 2024 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant