patch: eventDispatcher metrics, remove event type label and introduce scheme label #485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
denopink
commented
Oct 11, 2024
•
denopink
commented
- remove event type label
- add scheme label
- add tests for eventDispatcher metrics
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #485 +/- ##
==========================================
+ Coverage 59.15% 59.42% +0.26%
==========================================
Files 18 18
Lines 1496 1496
==========================================
+ Hits 885 889 +4
+ Misses 569 565 -4
Partials 42 42
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
denopink
changed the title
url label to unknown
denopink
commented
Oct 11, 2024
denopink
changed the title
denopink
force-pushed
the
denopink/patch/remove-url-label-for-unsupported_events
branch
2 times, most recently
from
6c3cc9c
to
473d831
Compare
denopink
commented
Oct 14, 2024
| err = ErrorUnroutableDestination | ||
| d.logger.Error("Unroutable destination", zap.Any("destination", destination)) | ||
| } | ||
| scheme, err = d.routeMessageReceivedEvent(event) |
There was a problem hiding this comment.
took this opportunity to make the code more readable/maintainable and reduce its cognitive load
denopink
commented
Oct 14, 2024
schmidtw
approved these changes
Oct 14, 2024
… scheme label - remove event type label - add scheme label - add tests for eventDispatcher metrics
denopink
force-pushed
the
denopink/patch/remove-url-label-for-unsupported_events
branch
from
473d831
to
b62d065
Compare
denopink
deleted the
denopink/patch/remove-url-label-for-unsupported_events
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.