Dependencies update & making prometheus endpoint set up async

xmidt-org · Nov 28, 2017 · d888a61 · d888a61
1 parent 1f5ad5e
commit d888a61
Show file tree

Hide file tree

Showing 2 changed files with 35 additions and 5 deletions.
diff --git a/src/glide.lock b/src/glide.lock
diff --git a/src/tr1d1um/tr1d1um.go b/src/tr1d1um/tr1d1um.go
@@ -143,10 +143,13 @@ func tr1d1um(arguments []string) (exitCode int) {
 
 	go snsFactory.PrepareAndStart()
 
+	// prometheus metrics set up
 	http.Handle("/metrics", promhttp.Handler())
-	if prometheusEndpointErr := http.ListenAndServe(":8080", nil); prometheusEndpointErr != nil {
-		errorLogger.Log(logging.MessageKey(), "error with prometheus endpoint", logging.ErrorKey(), prometheusEndpointErr)
-	}
+	go func() {
+		if prometheusEndpointErr := http.ListenAndServe(":8080", nil); prometheusEndpointErr != nil {
+			errorLogger.Log(logging.MessageKey(), "error with prometheus endpoint", logging.ErrorKey(), prometheusEndpointErr)
+		}
+	}()
 
 	if err := concurrent.Await(tr1d1umServer, signals); err != nil {
 		fmt.Fprintf(os.Stderr, "Error when starting %s: %s", applicationName, err)
@@ -329,6 +332,6 @@ func main() {
 }
 
 func init() {
-	// Metrics have to be registered to be exposed:
+	// Metrics values must be registered to be exposed:
 	prometheus.MustRegister(requestsReceived)
 }