@xmpp/connection disconnect - Cannot read properties of null (reading 'end')

[filipw01]

Describe the bug
Calling client?.disconnect it's possible that this.socket is undefined

Logs
I didn't get a chance to reproduce it locally. Only attaching sentry logs

I suspect it could be a case when client is already disconnected but please let me know if I should provide more logs/reproduction

Environment
Browser

[sonnyp]

I agree it should throw if socket is undefined.

Can you send a PR?

xmpp.js/packages/connection/index.js

Line 238 in d5260a1

async disconnect(timeout = this.timeout) {

[adarsh7raj]

Can we do this : if (!this.socket) {
console.warn("No active socket to disconnect.");
return; // Exit if there is no socket to disconnect
}
This will give a warning that socket does not exist and and the line (this.socket.end) will not run and it will not throw an error.