Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force babel compilation check on pre-commit #34

Open
xnt opened this issue Oct 6, 2019 · 1 comment
Open

Force babel compilation check on pre-commit #34

xnt opened this issue Oct 6, 2019 · 1 comment
Labels
feature request New feature or request first-timers-only good first issue Good for newcomers

Comments

@xnt
Copy link
Owner

xnt commented Oct 6, 2019

I've had a couple of instances where I (or another contributor) forget to add a , to one of the items in the messages array. I thought this would be caught by eslint, but apparently it isn't 🤷‍♂️.

So let's try to hook the full babel compilation (and assert a successful result) to the pre-commit. I suspect this might be as easy as adding the command to the pre-commit hook in husky.

@xnt xnt added feature request New feature or request good first issue Good for newcomers first-timers-only labels Oct 6, 2019
@saichandernagamalla
Copy link

Hello @xnt
eslint is able to caught the missing commas at pre-commit stage. I'm able to test it and it is failing the commit.
Possible reason might be, non availability of husky package in node_modules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request first-timers-only good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants