number of desktop

[alozovskoy]

Hi!
WMFS didn't set the _NET_WM_DESKTOP properties for a windows, but set the _WMFS_TAG. It's no good, because it is nonstandarted.

Sorry! My english is bad. =(

[soulthreads]

Yes, and it also wouldn't be too hard to implement. Here I wrote quickly some sort of fix for that:

diff --git a/src/client.c b/src/client.c
index f96869a..dd8528a 100644
--- a/src/client.c
+++ b/src/client.c
@@ -1023,6 +1023,8 @@ client_update_props(struct client *c, Flags f)
      {
           XChangeProperty(W->dpy, c->win, ATOM("_WMFS_TAG"), XA_CARDINAL, 32,
                           PropModeReplace, (unsigned char*)&(c->tag->id), 1);
+          XChangeProperty(W->dpy, c->win, ATOM("_NET_WM_DESKTOP"), XA_CARDINAL, 32,
+                          PropModeReplace, (unsigned char*)&(c->tag->id), 1);

           XChangeProperty(W->dpy, c->win, ATOM("_WMFS_SCREEN"), XA_CARDINAL, 32,
                           PropModeReplace, (unsigned char*)&(c->screen->id), 1);

Maybe, there are much better way to do this, but it works.

[soulthreads]

Oh, that's not enough… wmfs should also respond to the event _NET_WM_CURRENT_DESKTOP to be able to switch to another desktop when it is requested by pager for example.

[linkdd]

_WMFS_TAG and _NET_WM_DESKTOP aren't the same.

_WMFS_TAG works in multi-head configuration because it's a "tag" in a "screen". But a desktop is what you have on all screens.

Take example in GNOME, KDE, and Openbox :

• on multi-head configuration, when you switch to another virtual desktop, all your screens are changed.

I'm not sure if I explain that correctly, but the design of a tag and a desktop are totally different, and what you've done is definitely not enough.

[soulthreads]

OK, I get it. But is there a way to implement proper behaviour so that EWMH will be used without interferring with wmfs tags? I'm not sure, but it seems that awesome wm handles that situation right.