Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for putting cooldowns on a timeline via a replay #471

Merged
merged 2 commits into from
Dec 29, 2023

Conversation

xpdota
Copy link
Owner

@xpdota xpdota commented Dec 23, 2023

This allows you to copy cooldown usages from an import (fflogs/act log/etc) onto your custom timeline.

UI will be cleaned up before this gets released.

Steps to use:

  1. Import something (fflogs, ACT log, or triggevent session)
  2. If using an ACT log or session file, advance the replay to the beginning of the pull that you want to import mits from. This isn't necessary with fflogs since you only import a single pull at a time.
  3. Click the new "Record" button in the bottom-right corner of the Plugin Settings -> Timelines tab (see below)
  4. Wait for it to run through the entire pull, then click "Accept"
    image

By default, each entry will be imported as a job-locked timeline entry without a trigger enabled.

Recording will replace all previously recorded timeline entries for that zone, but should not remove any custom entries which were not imported/recorded.

Known issues:

  • UI sucks
  • Doesn't always correctly handle the second phase of doorboss fights, since it may take some time to sync

Copy link
Contributor

Once this branch successfully builds, you will be able to try the branch out for yourself by changing the "branch" in your updater to "timeline-import" (without the quotes).
This setting can be found under the "Updates" tab.

Don't forget to change back when you are done testing. You should reset your branch either to 'stable' for normal releases, or 'master' for beta builds.

@xpdota xpdota merged commit c9dea5e into master Dec 29, 2023
2 checks passed
@xpdota xpdota deleted the timeline-import branch December 29, 2023 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant