Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove all function_exists for extension checking on Client class #15

Open
peter279k opened this issue Jul 24, 2020 · 1 comment
Open

Remove all function_exists for extension checking on Client class #15

peter279k opened this issue Jul 24, 2020 · 1 comment

Comments

@peter279k
Copy link

As title, it seems that Client class do many function_exists functions to check whether required PHP extensions are loaded.

Such as curl, json and so on.

I think it's time to be removed and it can also move them to require block on composer.json.

And it can check extensions are loaded correctly during composer install command running.

Once this issue is accepted by @xperseguers, I would be happy to work on this :).
@xperseguers
Copy link
Owner

Feel free to create a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@xperseguers @peter279k