Add Bazel support #273
Open
Add Bazel support #273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vertexwahn
force-pushed
the
add-bazel-support
branch
2 times, most recently
from
c3056e0
to
16f2687
Compare
Vertexwahn
force-pushed
the
add-bazel-support
branch
3 times, most recently
from
5a0d96a
to
6b9009b
Compare
Vertexwahn
force-pushed
the
add-bazel-support
branch
from
6b9009b
to
ff84a80
Compare
|
Hi @Vertexwahn , and thank you for your contribution.
I am not fan of providing sometihng that potentially does not work, meaning this build should be tested and maintained. However, we have limited bandwidth, and I won't be able to maintain this myself; so is that something you plan to maintain on the long run? Another approach could be to have the Bazel build of xtl in a dedicated repo. |
|
@JohanMabille I can maintain it at least for the next 6 months. After this period we can decide if this is dropped again or if I can continue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR helps users of the Bazel build system to integrate xtl in their builds.
Supporting two build systems (CMake and Bazel) is of course more effort to maintain but helps to spread xtl.
In the worst case the Bazel build does simply not work - in the best case, someone who uses Bazel can benefit from it.
Also, other projects support CMake and Bazel side by side (e.g. Catch2, gtest, etc.)