XWIKI-18816: Useless and somewhat invalid <dt> markup on the login form #3379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Updated the DOM of the login form to be valid HTML
Sereza7
added
backport stable-15.10.x
michitux
reviewed
Aug 29, 2024
| @@ -216,6 +216,7 @@ div.suggestItems .hide-button { | |||
| margin-top: .3em; | |||
| } | |||
| .submitSection { | |||
| margin-top: floor(@font-size-base * 1.4); // Same as `.xform dl dt` | |||
There was a problem hiding this comment.
Minor comment, I think we normally put comments on their own line in our code style.
There was a problem hiding this comment.
Addressed in 636b1f9 👍
* Fixed comment codestyle and reordered in order to keep the scope of the comment easy to figure out.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira URL
https://jira.xwiki.org/browse/XWIKI-18816
Changes
Description
Screenshots & Video
after the changes in the PR, manual tests did not show any change in the visual interface:
Executed Tests
The selector for the submit button is here:
xwiki-platform/xwiki-platform-core/xwiki-platform-test/xwiki-platform-test-ui/src/main/java/org/xwiki/test/ui/po/LoginPage.java
Line 45 in 9ab1290
It shouldn't stop working with the changes.
I could not find any element selector for the recovery links in this file or by searching
.xAdditional.Expected merging strategy