core: Add unit test to cover basic SQLite functionalities. (#380)

Co-authored-by: kirkrodrigues <2454684+kirkrodrigues@users.noreply.github.com>
y-scope · May 13, 2024 · 0611040 · 0611040
1 parent 9ccefad
commit 0611040
Show file tree

Hide file tree

Showing 4 changed files with 430 additions and 0 deletions.
diff --git a/components/core/CMakeLists.txt b/components/core/CMakeLists.txt
@@ -431,6 +431,7 @@ set(SOURCE_FILES_unitTest
         tests/test-ParserWithUserSchema.cpp
         tests/test-query_methods.cpp
         tests/test-Segment.cpp
+        tests/test-SQLiteDB.cpp
         tests/test-Stopwatch.cpp
         tests/test-StreamingCompression.cpp
         tests/test-string_utils.cpp

diff --git a/components/core/src/clp/SQLiteDB.cpp b/components/core/src/clp/SQLiteDB.cpp
@@ -19,6 +19,15 @@ void SQLiteDB::open(string const& path) {
     }
 }
 
+SQLiteDB::~SQLiteDB() {
+    if (nullptr == m_db_handle) {
+        return;
+    }
+    if (false == close()) {
+        SPDLOG_WARN("Failed to close underlying SQLite database - this may cause a memory leak.");
+    }
+}
+
 bool SQLiteDB::close() {
     auto return_value = sqlite3_close(m_db_handle);
     if (SQLITE_BUSY == return_value) {

diff --git a/components/core/src/clp/SQLiteDB.hpp b/components/core/src/clp/SQLiteDB.hpp
@@ -25,6 +25,9 @@ class SQLiteDB {
     // Constructors
     SQLiteDB() : m_db_handle(nullptr) {}
 
+    // Destructor
+    ~SQLiteDB();
+
     // Methods
     void open(std::string const& path);
     bool close();