Taskfile: Download and set up Meteor.js as part of building the packa…

…ge; Refactor tarball download and extraction into reusable task. (#363)

.github/workflows/clp-lint.yaml

@@ -19,16 +19,6 @@ jobs:
         with:
           python-version: "3.11"
 
-      - id: "parse_meteor_version"
-        run: |-
-          release_file="./components/webui/.meteor/release"
-          meteor_version=$(grep --only-matching --perl-regexp "[\d.]+" $release_file)
-          echo "meteor_version=${meteor_version}" | tee --append $GITHUB_OUTPUT
-
-      - uses: "meteorengineer/setup-meteor@v1"
-        with:
-          meteor-release: "${{steps.parse_meteor_version.outputs.meteor_version}}"
-
       - name: "Install task"
         shell: "bash"
         run: "npm install -g @go-task/cli"

Taskfile.yml

@@ -8,11 +8,12 @@ vars:
   # Paths
   G_BUILD_DIR: "{{.ROOT_DIR}}/build"
   G_CORE_COMPONENT_BUILD_DIR: "{{.G_BUILD_DIR}}/core"
+  G_METEOR_BUILD_DIR: "{{.G_BUILD_DIR}}/meteor"
   G_PACKAGE_BUILD_DIR: "{{.G_BUILD_DIR}}/clp-package"
   G_PACKAGE_VENV_DIR: "{{.G_BUILD_DIR}}/package-venv"
   G_WEBUI_BUILD_DIR: "{{.G_BUILD_DIR}}/webui"
   G_WEBUI_NODEJS_BUILD_DIR: "{{.G_BUILD_DIR}}/webui-nodejs"
-  G_WEBUI_NODEJS_BIN_DIR: "{{.G_WEBUI_NODEJS_BUILD_DIR}}/node/bin"
+  G_WEBUI_NODEJS_BIN_DIR: "{{.G_WEBUI_NODEJS_BUILD_DIR}}/bin"
 
   # Versions
   G_PACKAGE_VERSION: "0.0.3-dev"
@@ -170,6 +171,7 @@ tasks:
   webui:
     deps:
       - "init"
+      - "meteor"
       - task: "validate-checksum"
         vars:
           CHECKSUM_FILE: "{{.CHECKSUM_FILE}}"
@@ -183,20 +185,24 @@ tasks:
     cmds:
       - "rm -rf '{{.OUTPUT_DIR}}'"
       - "mkdir -p '{{.OUTPUT_DIR}}'"
-      - "meteor build --directory '{{.OUTPUT_DIR}}'"
+      - "PATH='{{.G_METEOR_BUILD_DIR}}':$PATH meteor build --directory '{{.OUTPUT_DIR}}'"
       - >-
         rsync -a
         "{{.OUTPUT_DIR}}/bundle/"
         launcher.js
         settings.json
         "{{.OUTPUT_DIR}}/"
       - "rm -rf '{{.OUTPUT_DIR}}/bundle/'"
+      # Remove temp files generated by `meteor build` before checksum
+      - "find node_modules -type f -name '.meteor-portable-2.json' -exec rm {} +"
       # This command must be last
       - task: "compute-checksum"
         vars:
           DATA_DIR: "{{.OUTPUT_DIR}}"
           OUTPUT_FILE: "{{.CHECKSUM_FILE}}"
     sources:
+      - "{{.G_BUILD_DIR}}/meteor.md5"
+      - "{{.G_BUILD_DIR}}/webui-node-modules.md5"
       - "{{.TASKFILE}}"
       - "*"
       - ".meteor/*"
@@ -207,59 +213,100 @@ tasks:
     generates: ["{{.CHECKSUM_FILE}}"]
 
   webui-nodejs:
+    internal: true
     vars:
       CHECKSUM_FILE: "{{.G_BUILD_DIR}}/{{.TASK}}.md5"
       OUTPUT_DIR: "{{.G_WEBUI_NODEJS_BUILD_DIR}}"
+    cmds:
+      - task: "nodejs"
+        vars:
+          CHECKSUM_FILE: "{{.CHECKSUM_FILE}}"
+          NODEJS_VERSION: "v14.21.3"
+          OUTPUT_DIR: "{{.OUTPUT_DIR}}"
+
+  core-submodules:
+    internal: true
+    dir: "components/core"
+    vars:
+      CHECKSUM_FILE: "{{.G_BUILD_DIR}}/{{.TASK}}.md5"
+      OUTPUT_DIR: "submodules"
     deps:
       - "init"
       - task: "validate-checksum"
         vars:
           CHECKSUM_FILE: "{{.CHECKSUM_FILE}}"
           DATA_DIR: "{{.OUTPUT_DIR}}"
     cmds:
-      - task: "nodejs"
-        vars:
-          NODEJS_VERSION: "v14.21.3"
-          OUTPUT_DIR: "{{.OUTPUT_DIR}}"
+      - "tools/scripts/deps-download/download-all.sh"
       # This command must be last
       - task: "compute-checksum"
         vars:
           DATA_DIR: "{{.OUTPUT_DIR}}"
           OUTPUT_FILE: "{{.CHECKSUM_FILE}}"
     sources:
       - "{{.TASKFILE}}"
+      - ".gitmodules"
+      - "tools/scripts/deps-download/**/*"
     generates: ["{{.CHECKSUM_FILE}}"]
 
-  core-submodules:
+  download-and-extract-tar:
     internal: true
-    dir: "components/core"
+    requires:
+      vars: ["CHECKSUM_FILE", "EXTRACTED_DIR_NAME", "TAR_NAME", "OUTPUT_DIR", "URL_PREFIX"]
+    label: "{{.TASK}}-{{.TAR_NAME}}"
     vars:
-      CHECKSUM_FILE: "{{.G_BUILD_DIR}}/{{.TASK}}.md5"
-      OUTPUT_DIR: "submodules"
+      OUTPUT_TMP_DIR: "{{.OUTPUT_DIR}}-tmp"
+      EXTRACTED_DIR: "{{.OUTPUT_TMP_DIR}}/{{.EXTRACTED_DIR_NAME}}"
+      TAR_PATH: "{{.OUTPUT_TMP_DIR}}/{{.TAR_NAME}}"
     deps:
       - "init"
       - task: "validate-checksum"
         vars:
           CHECKSUM_FILE: "{{.CHECKSUM_FILE}}"
           DATA_DIR: "{{.OUTPUT_DIR}}"
     cmds:
-      - "tools/scripts/deps-download/download-all.sh"
+      - "rm -rf '{{.OUTPUT_DIR}}' '{{.OUTPUT_TMP_DIR}}'"
+      - "mkdir -p '{{.OUTPUT_TMP_DIR}}'"
+      - >-
+        curl --fail --location --show-error
+        "{{.URL_PREFIX}}/{{.TAR_NAME}}"
+        --output "{{.TAR_PATH}}"
+      - "tar xf '{{.TAR_PATH}}' --directory '{{.OUTPUT_TMP_DIR}}'"
+      - "mv '{{.EXTRACTED_DIR}}' '{{.OUTPUT_DIR}}'"
+      - "rm -rf '{{.OUTPUT_TMP_DIR}}'"
       # This command must be last
       - task: "compute-checksum"
         vars:
           DATA_DIR: "{{.OUTPUT_DIR}}"
           OUTPUT_FILE: "{{.CHECKSUM_FILE}}"
-    sources:
-      - "{{.TASKFILE}}"
-      - ".gitmodules"
-      - "tools/scripts/deps-download/**/*"
+    sources: ["{{.TASKFILE}}"]
     generates: ["{{.CHECKSUM_FILE}}"]
 
+  meteor:
+    run: "once"
+    preconditions:
+      - sh: >-
+          (test "$(uname -m)" != "aarch64") || (test "$(uname -s)" != "Linux")
+        msg: "Meteor 2.x does not support aarch64 on Linux"
+    vars:
+      CHECKSUM_FILE: "{{.G_BUILD_DIR}}/{{.TASK}}.md5"
+      METEOR_ARCH: "{{ if eq ARCH \"arm64\" }}arm64{{ else }}x86_64{{ end }}"
+      METEOR_PLATFORM: "{{ if eq OS \"darwin\" }}osx{{ else }}linux{{ end }}"
+      METEOR_RELEASE: "2.15"
+    cmds:
+      - task: "download-and-extract-tar"
+        vars:
+          CHECKSUM_FILE: "{{.CHECKSUM_FILE}}"
+          EXTRACTED_DIR_NAME: ".meteor"
+          OUTPUT_DIR: "{{.G_METEOR_BUILD_DIR}}"
+          TAR_NAME: "meteor-bootstrap-os.{{.METEOR_PLATFORM}}.{{.METEOR_ARCH}}.tar.gz"
+          URL_PREFIX: "https://static.meteor.com/packages-bootstrap/{{.METEOR_RELEASE}}"
+
   nodejs:
     internal: true
     deps: ["init"]
     requires:
-      vars: ["NODEJS_VERSION", "OUTPUT_DIR"]
+      vars: ["CHECKSUM_FILE", "NODEJS_VERSION", "OUTPUT_DIR"]
     vars:
       NODEJS_ARCH: "{{ if eq ARCH \"arm64\" }}arm64{{ else }}x64{{ end }}"
       NODEJS_VERSION_BASE_URL: "https://nodejs.org/dist/{{.NODEJS_VERSION}}/"
@@ -272,19 +319,14 @@ tasks:
           --max-count 1
           "node-v\\d+\\.\\d+\\.\\d+-linux-{{.NODEJS_ARCH}}"
           | head --lines 1
-      NODEJS_FILE_TAR_NAME: "{{.NODEJS_FILE_BASE_NAME}}.tar.xz"
     cmds:
-      - "rm -rf '{{.OUTPUT_DIR}}/node'"
-      - "mkdir -p '{{.OUTPUT_DIR}}'"
-      - >-
-        curl -fsSL
-        "{{.NODEJS_VERSION_BASE_URL}}{{.NODEJS_FILE_TAR_NAME}}"
-        -o "{{.OUTPUT_DIR}}/{{.NODEJS_FILE_TAR_NAME}}"
-      - "tar xf '{{.OUTPUT_DIR}}/{{.NODEJS_FILE_TAR_NAME}}' --directory '{{.OUTPUT_DIR}}'"
-      - >-
-        mv "{{.OUTPUT_DIR}}/{{.NODEJS_FILE_BASE_NAME}}"
-        "{{.OUTPUT_DIR}}/node"
-      - "rm -f '{{.OUTPUT_DIR}}/{{.NODEJS_FILE_TAR_NAME}}'"
+      - task: "download-and-extract-tar"
+        vars:
+          CHECKSUM_FILE: "{{.CHECKSUM_FILE}}"
+          TAR_NAME: "{{.NODEJS_FILE_BASE_NAME}}.tar.xz"
+          EXTRACTED_DIR_NAME: "{{.NODEJS_FILE_BASE_NAME}}"
+          URL_PREFIX: "{{.NODEJS_VERSION_BASE_URL}}"
+          OUTPUT_DIR: "{{.OUTPUT_DIR}}"
 
   package-venv:
     internal: true
@@ -355,19 +397,21 @@ tasks:
     dir: "{{.WEBUI_SRC_DIR}}"
     deps:
       - "init"
+      - "meteor"
       - task: "validate-checksum"
         vars:
           CHECKSUM_FILE: "{{.CHECKSUM_FILE}}"
           DATA_DIR: "{{.OUTPUT_DIR}}"
     cmds:
       - "rm -rf '{{.OUTPUT_DIR}}'"
-      - "meteor npm install --production"
+      - "PATH='{{.G_METEOR_BUILD_DIR}}':$PATH meteor npm install --production"
       # This command must be last
       - task: "compute-checksum"
         vars:
           DATA_DIR: "{{.OUTPUT_DIR}}"
           OUTPUT_FILE: "{{.CHECKSUM_FILE}}"
     sources:
+      - "{{.G_BUILD_DIR}}/meteor.md5"
       - "{{.TASKFILE}}"
       - ".meteor/packages"
       - "package.json"

docs/src/dev-guide/building-package.md

@@ -12,9 +12,6 @@ prebuilt version instead, check out the [releases](https://github.com/y-scope/cl
     extra configuration.
 * Python 3.8 or newer
 * python3-venv
-* [Node.js 14](https://nodejs.org/download/release/v14.21.3/) (Meteor.js only
-  [supports](https://docs.meteor.com/install#prereqs-node) Node.js versions >= 10 and <= 14)
-* [Meteor.js](https://docs.meteor.com/install.html#installation)
 * [Task](https://taskfile.dev/)
 
 ## Setup

lint-tasks.yml

@@ -2,7 +2,7 @@ version: "3"
 
 vars:
   G_LINTER_NODEJS_BUILD_DIR: "{{.G_BUILD_DIR}}/linter-nodejs"
-  G_LINTER_NODEJS_BIN_DIR: "{{.G_LINTER_NODEJS_BUILD_DIR}}/node/bin"
+  G_LINTER_NODEJS_BIN_DIR: "{{.G_LINTER_NODEJS_BUILD_DIR}}/bin"
   G_LINT_VENV_DIR: "{{.G_BUILD_DIR}}/lint-venv"
 
 tasks:
@@ -146,26 +146,12 @@ tasks:
     vars:
       CHECKSUM_FILE: "{{.G_BUILD_DIR}}/{{.TASK | replace \":\" \"#\"}}.md5"
       OUTPUT_DIR: "{{.G_LINTER_NODEJS_BUILD_DIR}}"
-    deps:
-      - ":init"
-      - task: ":validate-checksum"
-        vars:
-          CHECKSUM_FILE: "{{.CHECKSUM_FILE}}"
-          DATA_DIR: "{{.OUTPUT_DIR}}"
     cmds:
       - task: ":nodejs"
         vars:
+          CHECKSUM_FILE: "{{.CHECKSUM_FILE}}"
           NODEJS_VERSION: "latest"
           OUTPUT_DIR: "{{.OUTPUT_DIR}}"
-      # This command must be last
-      - task: ":compute-checksum"
-        vars:
-          DATA_DIR: "{{.OUTPUT_DIR}}"
-          OUTPUT_FILE: "{{.CHECKSUM_FILE}}"
-    sources:
-      - "{{.ROOT_DIR}}/Taskfile.yml"
-      - "{{.TASKFILE}}"
-    generates: ["{{.CHECKSUM_FILE}}"]
 
   linter-node-modules:
     internal: true