Apply code review comments

y-scope · May 6, 2024 · cc5b88c · cc5b88c
1 parent a8caea5
commit cc5b88c
Show file tree

Hide file tree

Showing 3 changed files with 181 additions and 197 deletions.
diff --git a/components/core/src/clp/SQLiteDB.cpp b/components/core/src/clp/SQLiteDB.cpp
@@ -19,6 +19,15 @@ void SQLiteDB::open(string const& path) {
     }
 }
 
+SQLiteDB::~SQLiteDB() {
+    if (nullptr == m_db_handle) {
+        return;
+    }
+    if (false == close()) {
+        SPDLOG_WARN("Memory leak due to failure of closing sqlite database.");
+    }
+}
+
 bool SQLiteDB::close() {
     auto return_value = sqlite3_close(m_db_handle);
     if (SQLITE_BUSY == return_value) {

diff --git a/components/core/src/clp/SQLiteDB.hpp b/components/core/src/clp/SQLiteDB.hpp
@@ -26,11 +26,7 @@ class SQLiteDB {
     SQLiteDB() : m_db_handle(nullptr) {}
 
     // Destructor
-    ~SQLiteDB() {
-        if (nullptr != m_db_handle) {
-            close();
-        }
-    }
+    ~SQLiteDB();
 
     // Methods
     void open(std::string const& path);