Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unhandled exceptions for some kinds of invalid JSON #514

Closed
gibber9809 opened this issue Aug 12, 2024 · 0 comments · Fixed by #503
Closed

Unhandled exceptions for some kinds of invalid JSON #514

gibber9809 opened this issue Aug 12, 2024 · 0 comments · Fixed by #503
Assignees
Labels
bug Something isn't working

Comments

@gibber9809
Copy link
Contributor

Bug

For some kinds of invalid JSON documents we are able to get a valid iterator to the illegal JSON document which later throws when we access a malformed field in the JSON document. Since we don't check if fields are valid in the parse_line function as we access them, and we don't have a try/catch around parse_line the exceptions goes uncaught and we lose out on properly reporting where the error occurred in the source file.

CLP version

0.1.2

Environment

ubuntu focal dev container

Reproduction steps

Ingest illegal JSON documents like
{"invalid": 17
and observe uncaught exception without log message telling us what file being ingested caused the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant