Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: Remove unsed bind methods from SQLitePreparedStatement. #379

Closed
wants to merge 1 commit into from

Conversation

LinZhihao-723
Copy link
Member

@LinZhihao-723 LinZhihao-723 commented May 1, 2024

References

Description

The current SQLitePreparedStatement implementation provides interfaces to bind a value with a string name parameter as the column name. However, this operation is ambiguous. For example, in a select statement, the column must appear in the selected list. After discussion, we decided to remove these methods from the implementations. Suppose a statement needs to bind values to a column specified by a string name. In that case, it should be implemented by a derived class rather than a generic SQLitePreparedStatement, which has a more clear specification on what the passed-in column name means.

Validation performed

  • Ensure all the workflow passed. The methods removed are not used in the current codebase. Removing them should not influence the core functionalities.

@LinZhihao-723
Copy link
Member Author

In retrospect, we decided to keep these methods since writing a generalized derived class is nontrivial given the breadth of SQL syntax.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant