core: Remove unsed bind methods from SQLitePreparedStatement. #379
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Description
The current
SQLitePreparedStatement
implementation provides interfaces tobind
a value with a string name parameter as the column name. However, this operation is ambiguous. For example, in a select statement, the column must appear in the selected list. After discussion, we decided to remove these methods from the implementations. Suppose a statement needs to bind values to a column specified by a string name. In that case, it should be implemented by a derived class rather than a genericSQLitePreparedStatement
, which has a more clear specification on what the passed-in column name means.Validation performed