Add support for linting on macOS and enable GH workflow for macOS. #383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wraymo
approved these changes
May 3, 2024
| --max-count 1 | ||
| "node-v\\d+\\.\\d+\\.\\d+-linux-{{.NODEJS_ARCH}}" | ||
| "node-v[[:digit:]]\+\.[[:digit:]]\+\.[[:digit:]]\+-{{OS}}-{{.NODEJS_ARCH}}" |
There was a problem hiding this comment.
Not for this PR, but I noticed we could remove the / at the end of line 303
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
linttasks are currently failing on macOS because of some Linux-specific command syntax that we're using. This PR switches to Linux/macOS-agnostic command syntax and enables the clp-lint workflow for macOS (so we have automated testing for linting on macOS).Itemized changes:
sed --regexp-extendedwithsed -E.--perl-regexpfrom thegrepcall and use the equivalent grep-compatible syntax.Validation performed
task lint:checkandtask lint:fixpass locally on a Linux host.clp-lintworkflow succeeds.task packagestill works.