linting: Always use latest versions of linting tools; Upgrade clang-format config. #384
Conversation
LinZhihao-723
changed the title
There was a problem hiding this comment.
Nice. Since we're now implicitly upgrading to clang-format 18, can we:
- Ensure we're not using any newly deprecated options.
- Add settings for rules introduced in clang-format 18?
lint-requirements.txt
Outdated
| clang-format~=17.0 | ||
| ruff~=0.1 | ||
| yamllint~=1.33 | ||
| black>=* |
There was a problem hiding this comment.
Why >=* rather than simply black
There was a problem hiding this comment.
On second thought, we should specify a minimum version since our configs will be version specific, and that would be a good way to indicate what version we configured them for.
There was a problem hiding this comment.
Shall we set them to the latest versions?
There was a problem hiding this comment.
Sgtm (the latest versions available on pypi)
|
There was a problem hiding this comment.
How about:
linting: Always use latest versions of linting tools; Upgrade clang-format config. (#384)
lgtm |
LinZhihao-723
changed the title
References
Description
The current listing tools are set to specific versions in our local linting tasks and GitHub linting workflow. However, these versions are getting outdated. For example, clang has released
clang-formatversion 18.1. Linting tool version updating normally includes more formatting standards and bug fixes. We should set the linting tool versions to the latest to apply these updates. Therefore, this PR updates the following things:lint-requirements.txtto install tools with the latest available versionsIn the future PR, we should set the workflow to run periodically for health-checking purposes.
Validation performed
tasklocally in Linux.