-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
core: Add unit test for LogEventSerializer. #431
Conversation
Before adding review comments, I think it's worth discussing the high-level concern here. The changes in
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will prefer to rewrite the test case to have log events to serialize stored in a vector (push whatever u have right now), and just loop through the vector for serialization/deserialization. The enumeration in this test case seems too verbose
Co-authored-by: kirkrodrigues <2454684+kirkrodrigues@users.noreply.github.com>
References
Description
Added unit test for LogEventSerializer and Deserializer
The unit test does the following:
Validation performed
New test is added to the unit test and passed