Taskfile: Remove container OS name and version from built package name. #497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junhaoliao
approved these changes
Jul 28, 2024
|
The PR title is fine for the final commit message. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The current name for package release builds is
clp-<flavour>-ubuntu-focal-<arch>-v<version>, where items in angle-brackets are populated with the relevant values. This name may imply to users that they can only use the release builds on Ubuntu Focal, but this isn't the case since we run all CLP components in Ubuntu Focal containers.This PR removes the OS name and version from the package release names to avoid confusion.
Validation performed
Validated that
task clp-text-pkg-tarandtask clp-json-pkg-tarbuilt package tars with names that didn't include the OS name and version.