Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webui: Optimize Meteor bundle size (fixes #498). #499

Merged
merged 3 commits into from
Jul 28, 2024

Conversation

junhaoliao
Copy link
Member

Description

  1. Add .meteorignore to exclude linter files from being bundled.
  2. Upgrade meteor to 2.16.
  3. Remove unused meteor packages (e.g. mobile-experience, typescript, shell-server) and one indirect dependency es5-shim from meteor packages specification file.

Validation performed

  1. Ran task clp-json-pkg-tar.
  2. Observed that
    1. build/clp-json-x86_64-v0.2.0-dev/ was generated, and the directory has a size of 609 MB (639,455,635 bytes) and contains 48,605 files, which is less than 656 MB (688,365,004 bytes) and
      56,433 files before the optimization.
    2. clp-json-x86_64-v0.2.0-dev.tar.gz was generated with size 175 MB (184,362,840 bytes), which is less than 185 MB (194,438,054 bytes) before the optimization.

@junhaoliao junhaoliao requested a review from kirkrodrigues July 28, 2024 19:27
@@ -4,16 +4,16 @@ babel-compiler@7.10.5
babel-runtime@1.5.1
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note this file was auto-updated by meteor upgrade after the packages specification changes in .meteor/packages.

@junhaoliao junhaoliao merged commit c2d1e40 into y-scope:main Jul 28, 2024
4 checks passed
jackluo923 pushed a commit to jackluo923/clp that referenced this pull request Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants