Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ffi: Add class for key-value pair log events. #507
ffi: Add class for key-value pair log events. #507
Changes from 16 commits
0da3f44
141f954
f3525aa
bbd3a56
b1fa61c
e148af7
f41e5d6
d29a17a
12679f7
534abf0
b7bed71
88aa36a
92c3388
698b406
bc565f5
2393038
285aab3
7623d76
ef0dd80
54ec36a
941fcbc
6623b5a
3ae389a
a066c67
353dccd
09dd01a
83ae4e0
7cd1ea7
6dd95a6
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I kinda feel like this can be moved into the value type validation method.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
prefer to leave it outside for two reasons:
Value
typehas_value()
and we don't need to symbols inside the helper (one for thestd::optional<Value>
and the over for the reference of the underlyingValue
)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Techinically it is possible to modify the original schema tree using this pointer in the class, right?
Should we consider using
std::shared_ptr<SchemaTree const>
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make sense