-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(core-clp): Remove unused functions from src/clp/Utils.*
.
#654
Conversation
WalkthroughThe pull request involves the removal of two utility functions, Changes
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
components/core/src/glt/Utils.cpp
Outdated
@@ -84,57 +84,6 @@ ErrorCode create_directory_structure(string const& path, mode_t mode) { | |||
return ErrorCode_Success; | |||
} | |||
|
|||
string get_parent_directory_path(string const& path) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Technically we don't have to remove those under src/glt/ since it is a different binary (and quite out of dated). but I guess it doesn't harm.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For title, how about
refactor(core-clp): Remove unused methods from Utils.
@kirkrodrigues do you want to sanity check or suggest a new title? |
Since we have multiple files called utils, maybe let's make it more specific with |
Sure, refactor(core-clp): Remove unused methods from |
Should this be in the title or description (or both)? |
I feel just the title is fine. But since we are at here, can you also update the description? Thanks |
Yeah, with a period after if possible. |
src/clp/Utils.*
.
Description
This PR removes the functions get_parent_directory and get_unambiguous_path from src/clp/Utils.* as they were not being used.
Validation performed
Summary by CodeRabbit
clp
namespaces.get_parent_directory_path
andget_unambiguous_path
functions.These changes simplify the codebase by removing specific path handling utilities, indicating a potential shift in how directory paths are managed.