Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: mcap support #7

Merged
merged 1 commit into from
Sep 23, 2024
Merged

feat: mcap support #7

merged 1 commit into from
Sep 23, 2024

Conversation

egorchakov
Copy link
Contributor

@egorchakov egorchakov commented Sep 18, 2024 •
edited
Loading

  • add mcap readers (protobuf/ros2)
  • abstract tabular source processing
  • slimmer configs
  • add read-frames script

closes #1

@egorchakov egorchakov force-pushed the feat/mcap branch 2 times, most recently from 5b29f11 to 31e54fc Compare September 20, 2024 16:28
@sandhawalia
Copy link
Contributor

sandhawalia commented Sep 23, 2024 •
edited
Loading

successfully build the package and ran visualization with carla/yaak/mcap_protobuf. 💪🏽

sandhawalia
sandhawalia approved these changes Sep 23, 2024
View reviewed changes
Copy link
Contributor

@sandhawalia sandhawalia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments. Otherwise LGTM. Build locally and tested it.

@egorchakov
feat: mcap support
d9e1278 
- add mcap readers (protobuf/ros2)
- abstract tabular source processing
- slimmer configs
- add `read-frames` script
@egorchakov egorchakov merged commit 9a1e594 into main Sep 23, 2024
1 check passed
@egorchakov egorchakov deleted the feat/mcap branch September 23, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sandhawalia sandhawalia sandhawalia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support mcap datasets
2 participants
@egorchakov @sandhawalia