linting

src/App/components/Browse/index.js

@@ -1,6 +1,5 @@
-import React, { useState, useEffect } from 'react';
+import React from 'react';
 import { connect } from 'react-redux';
-import test from '../testSearchResult'
 import Beatmap from '../common/Beatmap'
 import Search from './Search';
 import VizSensor from 'react-visibility-sensor';

src/App/components/Downloads/DownloadedItems.js

@@ -1,4 +1,4 @@
-import React, { useContext, memo, useCallback } from 'react'
+import React, { useContext } from 'react'
 import { HistoryContext } from '../../../Providers/HistoryProvider';
 import DownloadsItem from './Item';
 

src/App/components/Downloads/DownloadsInQueue.js

@@ -1,4 +1,4 @@
-import React, { useContext, useCallback } from 'react';
+import React, { useContext } from 'react';
 import DownloadsItem from './Item';
 import { DownloadQueueContext } from '../../../Providers/DownloadQueueProvider'
 

src/App/components/Downloads/index.js

@@ -1,11 +1,9 @@
-import React, { useContext } from 'react'
+import React from 'react'
 import DownloadedItems from './DownloadedItems';
 import DownloadsInQueue from './DownloadsInQueue';
 import DownloadsInProgress from './DownloadsInProgress';
-import { HistoryContext } from '../../../Providers/HistoryProvider';
 
 const Downloads = ({ theme }) => {
-  //const { history } = useContext(HistoryContext);
   return (
     <React.Fragment>
       <DownloadsInProgress theme={theme} />

src/App/components/Matchs/AddMatch.js

@@ -6,7 +6,6 @@ import { connect } from 'react-redux';
 const AddMatch = ({ bot, theme, errors, ircUsername }) => {
   const [ reqMatchId, setReqMatchId ] = useState('');
   const error = errors.filter(id => id === reqMatchId).length === 1
-  const test = /^[0-9]{4,10}$/g;
   return (
     <React.Fragment>
       <TextInput

src/App/components/Matchs/MatchDetails/ControlsBar.js

@@ -1,8 +1,7 @@
 import React from 'react'
 import injectSheet from 'react-jss';
-import { Button, Text } from 'react-desktop/windows';
+import { Button } from 'react-desktop/windows';
 import renderIcons from '../../../utils/renderIcons';
-import store from '../../../../store';
 
 const styles = {
   ControlsBar: {
@@ -46,7 +45,6 @@ const ControlsBar = ({ classes, theme, match, close }) => {
           push
           color={theme.color}
           onClick={match.toggleAutoBeat}
-        // hidden={!beatmap.title}
         >
           {`AutoBeat: ${match.autoBeat ? ' on' : 'off'}`}
         </Button>

src/App/components/Matchs/MatchDetails/index.js

@@ -1,4 +1,4 @@
-import React, { useState } from 'react'
+import React from 'react'
 import Beatmap from '../../common/Beatmap'
 import PlayersList from './PlayersList'
 import ControlsBar from './ControlsBar';

src/App/components/Matchs/index.js

@@ -1,6 +1,6 @@
 // Affiche la liste des matchs si aucun match n'est selectionné 
 
-import React, { useState, useEffect } from 'react'
+import React, { useState } from 'react'
 import AddMatch from './AddMatch'
 import MatchListItem from './MatchListItem'
 

src/App/components/Nav.js

@@ -1,6 +1,6 @@
 import React, { useState } from 'react';
 import { connect } from 'react-redux';
-import { NavPane, NavPaneItem, Text } from 'react-desktop/windows';
+import { NavPane, NavPaneItem } from 'react-desktop/windows';
 import Start from './Start'
 import Matchs from './Matchs'
 import Browse from './Browse'

src/App/components/Settings/index.js

@@ -1,10 +1,8 @@
 import React, { useEffect } from 'react';
 import { connect } from 'react-redux'
 import { remote } from 'electron';
-import store from '../../../store';
 import Volume from './Volume'
 import History from './History';
-import { Button } from 'react-desktop/windows';
 import ConfLoader from './ConfLoader';
 import { updateVolume } from './actions';
 import Configuration from './Configuration';

src/App/components/Start/index.js

@@ -1,6 +1,6 @@
 import React, { useEffect, createRef } from 'react'
 import start from '../../../Bot';
-import { ProgressCircle, Button, Text } from 'react-desktop/windows';
+import { ProgressCircle, Button } from 'react-desktop/windows';
 import { connect } from 'react-redux';
 
 const Start = ({ connected, theme, irc, osuApi }) => {
@@ -9,6 +9,7 @@ const Start = ({ connected, theme, irc, osuApi }) => {
 
   useEffect(() => {
     that.current.parentNode.style.padding = 0; // Dirty way to custom react-desktop component
+  // eslint-disable-next-line react-hooks/exhaustive-deps
   }, [])
 
   return (

src/App/components/common/Beatmap/Cover.js

@@ -8,6 +8,7 @@ const Cover = ({ url, width, height }) => {
   useEffect(() => {
     isLoaded(false)
     cover.setAttribute('src', url);
+  // eslint-disable-next-line react-hooks/exhaustive-deps
   }, [url]);
 
   const style = {

src/App/components/common/Beatmap/DownloadBeatmapBtn.js

@@ -1,6 +1,6 @@
 import React, { useContext } from 'react';
 import renderIcons from '../../../utils/renderIcons'
-import { ProgressCircle, Button, Text } from 'react-desktop/windows';
+import { ProgressCircle, Button } from 'react-desktop/windows';
 import { DownloadQueueContext } from '../../../../Providers/DownloadQueueProvider'
 import { HistoryContext } from '../../../../Providers/HistoryProvider';
 

src/App/components/common/Beatmap/PreviewBeatmapBtn.js

@@ -1,5 +1,5 @@
 import React, { useState, useContext } from 'react';
-import { Button, Text } from 'react-desktop/windows';
+import { Button } from 'react-desktop/windows';
 import renderIcons from '../../../utils/renderIcons'
 import { AudioPlayerContext } from '../../../../Providers/AudioPlayerProvider';
 

src/App/components/common/Beatmap/index.js

@@ -1,4 +1,4 @@
-import React, { useState, useEffect, memo } from 'react';
+import React, { useState, useEffect, memo, useRef } from 'react';
 import Cover from './Cover'
 import { Button, Text } from 'react-desktop/windows';
 import DownloadBeatmapBtn from './DownloadBeatmapBtn'
@@ -18,14 +18,8 @@ const Beatmap = ({ theme, beatmap, width }) => {
   const [brightness, setBrightness] = useState(0.95)
   const [isPlaying, setIsPLaying] = useState(false)
   const { beatmapset_id, id, title, artist, creator, version, beatconnectDlLink } = beatmap;
-  // const playpreview = null;
-  // const downloadBeatmap = null;
-
-  let bpmFlash = null;
-
-  // const handleClick = () => {
-
-  // }
+
+  const bpmFlash = useRef(null);
 
   const style = isPlaying ? {
     width: width || '80%',
@@ -46,12 +40,13 @@ const Beatmap = ({ theme, beatmap, width }) => {
 
   useEffect(() => {
     if (isPlaying) {
-      bpmFlash = setInterval(() => {
+      bpmFlash.current = setInterval(() => {
         setBrightness(1.08)
         setTimeout(() => setBrightness(0.95), (60000 / beatmap.bpm) / 2.5)
       }, 60000 / beatmap.bpm)
     }
     return () => bpmFlash ? clearInterval(bpmFlash) : undefined
+  // eslint-disable-next-line react-hooks/exhaustive-deps
   }, [isPlaying])
 
   useEffect(() => {

src/App/utils/renderIcons.js

@@ -176,5 +176,7 @@ export default function(name, style) {
               L311.1,311.1z"/>
         </svg>
       );
+      default: 
+        return null
     }
   }

src/App/utils/timeSince.js

@@ -13,7 +13,7 @@ export default (timeStamp) => {
   if (secondsPast > 86400) {
     const day = timeStamp.getDate();
     const month = timeStamp.toDateString().match(/ [a-zA-Z]*/)[0].replace(" ", "");
-    const year = timeStamp.getFullYear() == now.getFullYear() ? "" : " " + timeStamp.getFullYear();
+    const year = timeStamp.getFullYear() === now.getFullYear() ? "" : " " + timeStamp.getFullYear();
     return day + " " + month + year;
   }
 }

src/Bot/BeatconnectApi.js

@@ -36,7 +36,7 @@ const getDlLink = (beatmapInfos, pretty, extra) => {
     '4': 'Loved', '3': 'Qualified', '2': 'Approved', '1': 'Ranked', '0': 'Pending', '-1': 'WIP', '-2': 'Graveyard'
   };
   if (extra) {
-    const { creator, approved, version, creator_id, bpm, max_combo, difficultyrating, diff_approach, mode } = extra;
+    const { creator, approved, version, creator_id, bpm, max_combo, diff_approach } = extra;
     return `[${status[approved] || ''}] [https://beatconnect.io/b/${id}/${unique_id} ${artist || ''} - ${title || ''}  [${version || ''}]] by [https://osu.ppy.sh/u/${creator_id} ${creator || 'peppy'}] | BPM ${bpm || 0} | AR ${diff_approach || 0} ${max_combo ? '| Max combo: ' + max_combo : ''}`;
   }
   if (pretty) return `[https://beatconnect.io/b/${id}/${unique_id} ${artist} - ${title}]`;

src/Bot/Bot.js

@@ -7,7 +7,7 @@ const { BeatconnectApi, getDlLink } = require('./BeatconnectApi');
 
 class Bot {
   constructor(configFile) {
-    this.regExp = [/.*?((?:\/[\w\.\-]+)+)/i, /.*?(?:\/[\w\.\-]+)+.*?(?:\/[\w\.\-]+)+.*?((?:\/[\w\.\-]+)+)/i];
+    this.regExps = [/.*?(?:\/[\w.-]+)+.*?(?:\/[\w.-]+)+.*?((?:\/[\w.-]+)+)/i];
     this.conf = configFile;
     this.targetServer = this.conf.userPreferences.targetServer;
     this.beatconnect = new BeatconnectApi(this.conf.beatconnectAPI.key);
@@ -44,7 +44,7 @@ class Bot {
 
   newMatch(id, matchName, ircRoom, creator, playerList) {
     console.log(`New match created : ${id} ${matchName} ${ircRoom} ${creator}`);
-    const alreadyExist = false;
+    let alreadyExist = false;
     this.matchs.map(match => {
       if (match.id === id)
         alreadyExist = true
@@ -102,12 +102,12 @@ class Bot {
   onMpMessage(matchId, msg) {
     this.matchs.map(match => {
       if (match.id === matchId) {
-        const { rawMsg, from, channel, text } = msg;
+        const { rawMsg } = msg;
         const { rawCommand, args } = rawMsg;
 
         if (rawCommand === 'PRIVMSG' && args[0].includes('mp')) {
           if (args[1].includes('Beatmap changed to')) {
-            const beatmapId = this.regExp[1].exec(args[1])[1].split('/').pop();
+            const beatmapId = this.regExps[0].exec(args[1])[1].split('/').pop();
             this.newBeatmap(beatmapId, matchId);
           } else if (args[1].includes('joined in')) {
             const player = args[1].split(' ').shift();
@@ -170,7 +170,7 @@ class Bot {
         if (!fromMp) { this.irc.pm(from, `You need to be in a multiplayer match to use this`); break; }
         const matchId = fromMp.split('_').pop();
         this.matchs.map(match => {
-          if (match.id = matchId)
+          if (match.id === matchId)
             this.sendMapById(match.beatmapset_id, fromMp, match.fullBeatmapData);
         });
         break;

src/Bot/msg/mpSettings.js

@@ -1,3 +1,4 @@
+/* eslint-disable array-callback-return */
 import store from "../../store";
 
 export default function(msg) {

src/Providers/HistoryProvider.js

@@ -1,7 +1,7 @@
 /* Provides download history from {localUser}/Documents/Beatconnect/history.json */
 import React, { Component } from 'react';
-import { remote, shell } from 'electron';
-import { outputJSON, readJson, ensureDir } from 'fs-extra';
+import { remote } from 'electron';
+import { outputJSON, readJson } from 'fs-extra';
 
 export const HistoryContext = React.createContext();
 
@@ -28,17 +28,6 @@ class HistoryProvider extends Component {
     }
   }
 
-  // componentDidUpdate(prevProps, prevState) {
-  //   console.log('update')
-  //   const { history } = this.state;
-  //   const prevHistory = prevState.history;
-  //   console.log('update', history, 'prev', prevHistory)
-  //   if (JSON.stringify(history) !== JSON.stringify(prevHistory)){
-  //     console.log('updateDIFF')
-  //     this._writeHistory()
-  //   }
-  // }
-
   save = (item) => {
     const { id, name } = item;
     let { history } = this.state;