v2.2.0 (#73)

* [#69] Implemented a protocol-based initializer in `FeatureFlagResolver` (#70)
* [#68] Added support for mutable `stores` in resolver configuration via a new implementation, `MutableFeatureFlagResolverConfiguration` (#72)

.github/workflows/run-tests.yml

@@ -25,4 +25,4 @@ jobs:
     steps:
     - uses: actions/checkout@v2
     - name: Lint Podspec
-      run: pod lib lint --verbose
+      run: pod lib lint --allow-warnings --verbose

.jazzy.yaml

@@ -9,6 +9,7 @@ custom_categories:
           - FeatureFlagResolver
           - FeatureFlagResolverError
           - FeatureFlagResolverConfiguration
+          - MutableFeatureFlagResolverConfiguration
           - TransparentFeatureFlagStore
           - RuntimeOverridesStore
           - UserDefaultsStore

Sources/YMFF/FeatureFlagResolver/Configuration/MutableFeatureFlagResolverConfiguration.swift

@@ -0,0 +1,28 @@
+//
+//  MutableFeatureFlagResolverConfiguration.swift
+//  YMFF
+//
+//  Created by Yakov Manshin on 5/17/21.
+//  Copyright © 2021 Yakov Manshin. See the LICENSE file for license info.
+//
+
+#if !COCOAPODS
+import YMFFProtocols
+#endif
+
+// MARK: - MutableFeatureFlagResolverConfiguration
+
+/// An object used to configure the resolver, which holds feature flag stores that can be changed.
+final public class MutableFeatureFlagResolverConfiguration {
+
+    public var stores: [FeatureFlagStore]
+
+    public init(stores: [FeatureFlagStore]) {
+        self.stores = stores
+    }
+
+}
+
+// MARK: - FeatureFlagResolverConfigurationProtocol
+
+extension MutableFeatureFlagResolverConfiguration: FeatureFlagResolverConfigurationProtocol { }

Sources/YMFF/FeatureFlagResolver/FeatureFlagResolver.swift

@@ -21,10 +21,27 @@ final public class FeatureFlagResolver {
 
     // MARK: Initializers
 
-    public init(configuration: FeatureFlagResolverConfiguration) {
+    /// Initializes the resolver with an object that conforms to `FeatureFlagResolverConfigurationProtocol`.
+    ///
+    /// - Parameter configuration: *Required.* The configuration used to read and write feature flag values.
+    public init(configuration: FeatureFlagResolverConfigurationProtocol) {
         self.configuration = configuration
     }
 
+    @available(*, deprecated, message: "Use init(stores:)")
+    public convenience init(configuration: FeatureFlagResolverConfiguration) {
+        self.init(configuration: configuration as FeatureFlagResolverConfigurationProtocol)
+    }
+
+    /// Initializes the resolver with the list of feature flag stores.
+    ///
+    /// + Passing in an empty array will produce the `noStoreAvailable` error on next read attempt.
+    ///
+    /// - Parameter stores: *Required.* The array of feature flag stores.
+    public convenience init(stores: [FeatureFlagStore]) {
+        self.init(configuration: FeatureFlagResolverConfiguration(stores: stores))
+    }
+
     deinit {
         configuration.stores
             .compactMap({ $0.asMutable })

Tests/YMFFTests/FeatureFlagResolverConfigurationTests.swift

@@ -0,0 +1,35 @@
+//
+//  FeatureFlagResolverConfigurationTests.swift
+//  YMFF
+//
+//  Created by Yakov Manshin on 5/17/21.
+//  Copyright © 2021 Yakov Manshin. See the LICENSE file for license info.
+//
+
+import XCTest
+
+@testable import YMFF
+
+final class FeatureFlagResolverConfigurationTests: XCTestCase {
+
+    func testStoreAdditionToMutableConfiguration() {
+        let configuration = MutableFeatureFlagResolverConfiguration(stores: [])
+
+        XCTAssertEqual(configuration.stores.count, 0)
+
+        configuration.stores.append(.immutable(TransparentFeatureFlagStore()))
+
+        XCTAssertEqual(configuration.stores.count, 1)
+    }
+
+    func testStoreRemovalFromMutableConfiguration() {
+        let configuration = MutableFeatureFlagResolverConfiguration(stores: [.immutable(TransparentFeatureFlagStore())])
+
+        XCTAssertEqual(configuration.stores.count, 1)
+
+        configuration.stores.removeAll()
+
+        XCTAssertEqual(configuration.stores.count, 0)
+    }
+
+}

Tests/YMFFTests/MutableStoreTests.swift

@@ -72,7 +72,7 @@ final class MutableStoreTests: XCTestCase {
         mutableStore = MutableFeatureFlagStore(store: .init()) {
             saveChangesCount += 1
         }
-        resolver = FeatureFlagResolver(configuration: .init(stores: [.mutable(mutableStore)]))
+        resolver = FeatureFlagResolver(stores: [.mutable(mutableStore)])
 
         resolver = nil
 

Tests/YMFFTests/UserDefaultsStoreTests.swift

@@ -21,9 +21,9 @@ final class UserDefaultsStoreTests: XCTestCase {
     override func setUp() {
         super.setUp()
 
-        resolver = FeatureFlagResolver(configuration: .init(stores: [
+        resolver = FeatureFlagResolver(stores: [
             .mutable(UserDefaultsStore(userDefaults: userDefaults))
-        ]))
+        ])
     }
 
 }

YMFF.podspec

@@ -3,7 +3,7 @@ Pod::Spec.new do |s|
   # Basic Info
 
   s.name              = "YMFF"
-  s.version           = "2.1.0"
+  s.version           = "2.2.0"
   s.summary           = "Feature management made easy."
 
   s.description       = <<-DESC