Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#134] Refactored Feature-Flag Resolver Error #138

Merged
merged 5 commits into from
May 3, 2024
Merged

[#134] Refactored Feature-Flag Resolver Error #138

merged 5 commits into from
May 3, 2024

Conversation

yakovmanshin
Copy link
Owner

@yakovmanshin yakovmanshin commented May 2, 2024 •
edited
Loading

[Closes #134]

  • Renamed FeatureFlagResolverError to Error nested in FeatureFlagResolver (FeatureFlagResolver.Error)
  • Removed the noSyncStoreAvailable, noMutableStoreAvailable, noSyncMutableStoreAvailable, and noMutableStoreContainsValueForKey cases
  • Updated FeatureFlagResolver
  • Updated FeatureFlagResolverTests
  • Documented error cases

@yakovmanshin yakovmanshin added the optimization Code optimizations for improved performance label May 2, 2024
@yakovmanshin yakovmanshin added this to the v4.0.0 milestone May 2, 2024
@yakovmanshin yakovmanshin self-assigned this May 2, 2024
@yakovmanshin yakovmanshin enabled auto-merge (squash) May 2, 2024 23:46
@yakovmanshin yakovmanshin merged commit 8624a18 into main May 3, 2024
7 checks passed
@yakovmanshin yakovmanshin deleted the 134-refactored-FeatureFlagResolverError branch May 3, 2024 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@yakovmanshin yakovmanshin

Labels
optimization Code optimizations for improved performance
Projects
None yet
Milestone
v4.0.0
Development

Successfully merging this pull request may close these issues.

Refactor FeatureFlagResolverError
1 participant
@yakovmanshin