Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#131] Update All Mutable Stores When Setting or Removing Values #142

Merged
merged 5 commits into from
May 12, 2024

Conversation

yakovmanshin
Copy link
Owner

[Closes #131]

  • Previously, only the first mutable store was updated when FeatureFlagResolver received a call to set or remove a value
  • In this update, the behavior changes: Now all matching stores (i.e. mutable or synchronous mutable) are updated accordingly
  • If one of the stores throws an error in the process, this error is caught and kept by the resolver; this is to avoid incomplete operations where an error in a single store prevents updates to the others
  • After the remaining stores are updated; the last thrown error is re-thrown by the resolver

@yakovmanshin yakovmanshin added the new New feature or request label May 12, 2024
@yakovmanshin yakovmanshin added this to the v4.0.0 milestone May 12, 2024
@yakovmanshin yakovmanshin self-assigned this May 12, 2024
@yakovmanshin yakovmanshin enabled auto-merge (squash) May 12, 2024 00:54
@yakovmanshin yakovmanshin merged commit ec331f7 into main May 12, 2024
7 checks passed
@yakovmanshin yakovmanshin deleted the 131-update-all-mutable-stores branch May 12, 2024 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update all mutable stores when values are set or removed
1 participant