Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#148] Removed saveChanges() #149

Merged
merged 5 commits into from
May 12, 2024
Merged

[#148] Removed saveChanges() #149

merged 5 commits into from
May 12, 2024

Conversation

yakovmanshin
Copy link
Owner

@yakovmanshin yakovmanshin commented May 12, 2024 •
edited
Loading

[Closes #148]

  • The saveChanges() method was not needed for the majority of feature-flag stores
  • Only UserDefaultsStore had this method implemented
  • This change removes the method from protocols for mutable feature-flag stores
  • UserDefaultsStore synchronizes the changes in deinit
  • If a custom feature-flag store needs to save changes explicitly, it should implement an internal way to do so

@yakovmanshin yakovmanshin added the optimization Code optimizations for improved performance label May 12, 2024
@yakovmanshin yakovmanshin added this to the v4.0.0 milestone May 12, 2024
@yakovmanshin yakovmanshin self-assigned this May 12, 2024
@yakovmanshin yakovmanshin enabled auto-merge (squash) May 12, 2024 23:08
@yakovmanshin yakovmanshin merged commit 90460f3 into main May 12, 2024
7 checks passed
@yakovmanshin yakovmanshin deleted the 148-removed-saveChanges branch May 12, 2024 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@yakovmanshin yakovmanshin

Labels
optimization Code optimizations for improved performance
Projects
None yet
Milestone
v4.0.0
Development

Successfully merging this pull request may close these issues.

Remove saveChanges() from feature-flag store protocols
1 participant
@yakovmanshin