Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build error caused by this package and supports auto linking #380

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

maulikdhameliya
Copy link

  • Fix Build error

Task :react-native-orientation:verifyReleaseResources FAILED
FAILURE: Build failed with an exception.
Execution failed for task ':react-native-orientation:verifyReleaseResources'.

  • Supports autolinking

@maulikdhameliya
Copy link
Author

@yamill

@rcidt
Copy link

rcidt commented Apr 1, 2020

@maulikdhameliya this is fixed in latest master, but @yamill has not updated the npm package.

Therefore you should change the package reference in your package.json to:

{

    ...

    "dependencies": {

        ...

        "react-native-orientation": "https://github.com/tomyo-edtech/react-native-orientation#master",

        ...

    },

    ...

}

@maulikdhameliya
Copy link
Author

@rcidt sorry but this is different repo then the PR I created to.

    "react-native-orientation": "https://github.com/tomyo-edtech/react-native-orientation#master",

@mars-lan
Copy link

I ended up using this (which seems like a maintained fork) instead: https://github.com/wonday/react-native-orientation-locker

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants